Adjust amdgpu version output for amd-smi
#2563
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intention behind it was to avoid showing the string if it's not got information. Signed-off-by: Mario Limonciello <[email protected]>
superm1
force-pushed
the
amd/dev/mlimonci/amdgpu-version
branch
from
796db73 to
04c7624
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the amdgpu version output for amd-smi to hide the "amdgpu Version" line when no DKMS package is found (instead of showing "N/A") and adds a kernel version line to provide useful system information.
Key Changes:
- Modified conditional logic to hide "amdgpu Version" line when value is "N/A"
- Added kernel version display using
os.uname().release
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/amdsmi/amdsmi_cli/amdsmi_commands.py | Added kernel version to version_info dictionary using os.uname().release |
| projects/amdsmi/amdsmi_cli/amdsmi_logger.py | Updated conditional to properly hide amdgpu version when N/A and added kernel version output line |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This is an interesting debugging point, especially in the case of not having a DKMS package installed. Signed-off-by: Mario Limonciello <[email protected]> Signed-off-by: Mario Limonciello (AMD) <[email protected]>
superm1
force-pushed
the
amd/dev/mlimonci/amdgpu-version
branch
from
04c7624 to
b02cb2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that even though amd-smi is supposed to hide the amdgpu version when no dkms package found it was showing
N/A. I also believe it's useful to have the kernel version in this case. So I've got changes for both of those.Before:
After: